linux-kernel - Re: linux-next: build failure after merge of the irqchip tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48d3232d-0f1d-42ea-3109-f44bbabfa2e8@xilinx.com>
Date:   Mon, 23 Mar 2020 09:08:24 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Marc Zyngier <marc.zyngier@....com>
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Michal Simek <michal.simek@...inx.com>,
        Mubin Sayyed <mubin.usman.sayyed@...inx.com>
Subject: Re: linux-next: build failure after merge of the irqchip tree

Hi Stephen,

On 23. 03. 20 7:59, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the irqchip tree, today's linux-next build (powerpc
> ppc44x_defconfig) failed like this:
> 
> drivers/irqchip/irq-xilinx-intc.c: In function 'xil_intc_handle_irq':
> drivers/irqchip/irq-xilinx-intc.c:176:10: error: implicit declaration of function 'handle_domain_irq'; did you mean 'handle_bad_irq'? [-Werror=implicit-function-declaration]
>   176 |    ret = handle_domain_irq(irqc->root_domain, hwirq, regs);
>       |          ^~~~~~~~~~~~~~~~~
>       |          handle_bad_irq
> drivers/irqchip/irq-xilinx-intc.c: In function 'xilinx_intc_of_init':
> drivers/irqchip/irq-xilinx-intc.c:253:3: error: implicit declaration of function 'set_handle_irq'; did you mean 'generic_handle_irq'? [-Werror=implicit-function-declaration]
>   253 |   set_handle_irq(xil_intc_handle_irq);
>       |   ^~~~~~~~~~~~~~
>       |   generic_handle_irq
> 
> Caused by commit
> 
>   a0789993bf82 ("irqchip/xilinx: Enable generic irq multi handler")
> 
> I have reverted that commit (and commit
> 
>   9c2d4f525c00 ("irqchip/xilinx: Do not call irq_set_default_host()")
> 
> that conflicted with the other revert).
> 

thanks for reporting this.

Marc: I completely forget about this wiring for very ancient platform.
AFAIK Xilinx is not testing this platform for years and would likely the
best to remove support for it completely.
The second option is to get xintc_get_irq() back with note about powerpc
because it won't be that simple change all PPC platform to generic
domain irq handler.
Any other suggestion?

Thanks,
Michal