[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200323085241.GA342330@kroah.com>
Date: Mon, 23 Mar 2020 09:52:41 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Xiyu Yang <xiyuyang19@...an.edu.cn>
Cc: Arnd Bergmann <arnd@...db.de>,
Alexios Zavras <alexios.zavras@...el.com>,
Allison Randal <allison@...utok.net>,
Adit Ranadive <aditr@...are.com>,
Jorgen Hansen <jhansen@...are.com>,
Thomas Gleixner <tglx@...utronix.de>,
Vishnu DASA <vdasa@...are.com>, linux-kernel@...r.kernel.org,
yuanxzhang@...an.edu.cn, kjlu@....edu,
Xin Tan <tanxin.ctf@...il.com>
Subject: Re: [PATCH v2] VMCI: Fix NULL pointer dereference on context ptr
On Mon, Mar 23, 2020 at 04:22:33PM +0800, Xiyu Yang wrote:
> A NULL vmci_ctx object may pass to vmci_ctx_put() from its callers.
Are you sure this can happen?
> Add a NULL check to prevent NULL pointer dereference.
>
> Signed-off-by: Xiyu Yang <xiyuyang19@...an.edu.cn>
> Signed-off-by: Xin Tan <tanxin.ctf@...il.com>
> ---
> drivers/misc/vmw_vmci/vmci_context.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
What changed from v1?
Always put that below the --- line.
Please fix up and send a v3.
thanks,
greg k-h
Powered by blists - more mailing lists