linux-kernel - Re: [PATCH] clk: clk-flexgen: fix clock-critical handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f053f9c4-557c-d32b-7bc6-c3ff2c6fa966@st.com>
Date:   Mon, 23 Mar 2020 09:20:08 +0000
From:   Patrice CHOTARD <patrice.chotard@...com>
To:     Alain Volmat <avolmat@...com>,
        "mturquette@...libre.com" <mturquette@...libre.com>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: clk-flexgen: fix clock-critical handling

Hi Alain

On 3/22/20 3:07 PM, Alain Volmat wrote:
> Fixes an issue leading to having all clocks following a critical
> clocks marked as well as criticals.
>
> Fixes: fa6415affe20 ("clk: st: clk-flexgen: Detect critical clocks")
>
> Signed-off-by: Alain Volmat <avolmat@...com>
> ---
>  drivers/clk/st/clk-flexgen.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/st/clk-flexgen.c b/drivers/clk/st/clk-flexgen.c
> index 4413b6e04a8e..55873d4b7603 100644
> --- a/drivers/clk/st/clk-flexgen.c
> +++ b/drivers/clk/st/clk-flexgen.c
> @@ -375,6 +375,7 @@ static void __init st_of_flexgen_setup(struct device_node *np)
>  			break;
>  		}
>  
> +		flex_flags &= ~CLK_IS_CRITICAL;
>  		of_clk_detect_critical(np, i, &flex_flags);
>  
>  		/*


Reviewed-by: Patrice Chotard <patrice.chotard@...com>

Thanks

Patrice