linux-kernel - Re: [Xen-devel] [PATCH v3 1/2] xen: Use evtchn_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0d9d07e1-a828-28f2-b6ec-9d4d5bdc14be@oracle.com>
Date:   Mon, 23 Mar 2020 09:39:27 -0400
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Yan Yankovskyi <yyankovskyi@...il.com>,
        Jan Beulich <jbeulich@...e.com>
Cc:     Juergen Gross <jgross@...e.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Subject: Re: [Xen-devel] [PATCH v3 1/2] xen: Use evtchn_type_t as a type for
 event channels


On 3/23/20 1:33 AM, Yan Yankovskyi wrote:
> Make event channel functions pass event channel port using
> evtchn_port_t type. It eliminates signed <-> unsigned conversion.
>
> Signed-off-by: Yan Yankovskyi <yyankovskyi@...il.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>



>  
> @@ -1275,7 +1276,7 @@ void rebind_evtchn_irq(int evtchn, int irq)
>  
>  	mutex_unlock(&irq_mapping_update_lock);
>  
> -        bind_evtchn_to_cpu(evtchn, info->cpu);
> +	bind_evtchn_to_cpu(evtchn, info->cpu);


I'd leave this as is.