linux-kernel - Re: [PATCH v7 1/5] usb: hci: add hc_driver as argument for usb_hcd_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200323153745.GS72691@vkoul-mobl>
Date:   Mon, 23 Mar 2020 21:07:45 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Alan Stern <stern@...land.harvard.edu>
Cc:     Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Christian Lamparter <chunkeey@...glemail.com>,
        John Stultz <john.stultz@...aro.org>,
        Andreas Böhler <dev@...ehler.at>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mathias Nyman <mathias.nyman@...ux.intel.com>
Subject: Re: [PATCH v7 1/5] usb: hci: add hc_driver as argument for
 usb_hcd_pci_probe

On 23-03-20, 11:25, Alan Stern wrote:
> On Mon, 23 Mar 2020, Vinod Koul wrote:
> 
> > usb_hcd_pci_probe expects users to call this with driver_data set as
> > hc_driver, that limits the possibility of using the driver_data for
> > driver data.
> > 
> > Add hc_driver as argument to usb_hcd_pci_probe and modify the callers
> > ehci/ohci/xhci/uhci to pass hc_driver as argument and freeup the
> > driver_data used
> > 
> > Tested xhci driver on Dragon-board RB3, compile tested ehci and ohci.
> > Couldn't compile uhci
> > 
> > Suggested-by: Mathias Nyman <mathias.nyman@...ux.intel.com>
> > Signed-off-by: Vinod Koul <vkoul@...nel.org>
> > ---
> >  drivers/usb/core/hcd-pci.c  |  7 ++++---
> >  drivers/usb/host/ehci-pci.c |  6 ++----
> >  drivers/usb/host/ohci-pci.c |  9 ++++++---
> >  drivers/usb/host/uhci-pci.c |  8 ++++++--
> >  drivers/usb/host/xhci-pci.c | 14 +++++---------
> >  include/linux/usb/hcd.h     |  3 ++-
> >  6 files changed, 25 insertions(+), 22 deletions(-)
> 
> For all but the xHCI parts:
> 
> Acked-by: Alan Stern <stern@...land.harvard.edu>

Alan, Thanks for the quick ack. I will send v8 with your ack on first
patch (that touches *hci )

Thanks
-- 
~Vinod