linux-kernel - Re: [PATCH 0/2] io-uring: cleanup: drop completion upon removal of file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5f98097a-b3f7-fc8f-4a84-f848253a0e56@kernel.dk>
Date:   Mon, 23 Mar 2020 09:57:25 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Hillf Danton <hdanton@...a.com>
Cc:     syzbot <syzbot+538d1957ce178382a394@...kaller.appspotmail.com>,
        io-uring@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com,
        viro@...iv.linux.org.uk
Subject: Re: [PATCH 0/2] io-uring: cleanup: drop completion upon removal of
 file

On 3/23/20 3:24 AM, Hillf Danton wrote:
> 
> Kudos to the task hung reported by syzbot, and inspired by it, cleanup
> is made for dropping completion when files are removed from the fixed
> fileset. Another cleanup is also proposed for dropping the done field
> in struct io_file_put.
> 
> [PATCH 1/2] io_uring: drop completion when removing file
> [PATCH 2/2 RFC] io-uring: drop done in struct io_file_put

I like it - I applied, only changing 'done' to 'free_pfile' to make it
more apparent what it controls. Thanks!

-- 
Jens Axboe