linux-kernel - Re: [PATCH v1 0/2] Support built-in Mic on Tegra boards that use WM8903

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8b7a8eb3-98ed-71cb-5bd7-9c784ec24d68@gmail.com>
Date:   Mon, 23 Mar 2020 19:05:23 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Jon Hunter <jonathanh@...dia.com>,
        Stephen Warren <swarren@...dotorg.org>
Cc:     devicetree@...r.kernel.org, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Brown <broonie@...nel.org>, linux-tegra@...r.kernel.org
Subject: Re: [PATCH v1 0/2] Support built-in Mic on Tegra boards that use
 WM8903

23.03.2020 18:59, Jon Hunter пишет:
> 
> 
> On 20/03/2020 22:30, Stephen Warren wrote:
>> On 3/20/20 2:55 PM, Dmitry Osipenko wrote:
>>> Hello,
>>>
>>> This small series adds audio route for built-in microphone on NVIDIA Tegra
>>> boards that use WM8903 CODEC. In particular this is needed in order to unmute
>>> internal microphone on Acer A500 tablet device. I'm planning to send out the
>>> device tree for the A500 for 5.8, so will be nice to get the microphone
>>> sorted out. Please review and apply, thanks in advance.
>>
>> It's been a long time since I looked at this code, but the series looks
>> plausible,
>> Acked-by: Stephen Warren <swarren@...dia.com>
>>
>> (I wonder why machine->gpio_int_mic_en was already parse but never used!)
> 
> Looking at the ventana schematics, it appears that the internal-mic
> signals was connected to a header and not an actual mic, so maybe we
> never had a proper internal-mic on any board but allowed one to be
> connected.

I guess cardhu may have a mic, judging by downstream kernel sources (I
don't have cardhu schematics).

> Anyway, looks good to me as well.
> 
> Acked-by: Jon Hunter <jonathanh@...dia.com>

Thanks