linux-kernel - Re: [PATCH] dt-bindings: iio: accel: Add bmi088 accelerometer bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200323164102.00005abb@Huawei.com>
Date:   Mon, 23 Mar 2020 16:41:02 +0000
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Mike Looijmans <mike.looijmans@...ic.nl>
CC:     Jonathan Cameron <jic23@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <knaack.h@....de>, <lars@...afoo.de>, <pmeerw@...erw.net>,
        <robh+dt@...nel.org>, <mark.rutland@....com>
Subject: Re: [PATCH] dt-bindings: iio: accel: Add bmi088 accelerometer
 bindings

On Mon, 23 Mar 2020 10:56:41 +0100
Mike Looijmans <mike.looijmans@...ic.nl> wrote:

> On 22-03-2020 18:37, Jonathan Cameron wrote:
> > On Mon, 16 Mar 2020 07:52:18 +0100
> > Mike Looijmans <mike.looijmans@...ic.nl> wrote:
> >   
> >> This adds the device-tree bindings for the Bosch Sensortec BMI088 IMU,
> >> the accelerometer part.
> >>
> >> Signed-off-by: Mike Looijmans <mike.looijmans@...ic.nl>
> >> ---
> >>   .../devicetree/bindings/iio/accel/bmi088.txt  | 23 +++++++++++++++++++  
> > 
> > Sorry.  All new DT bindings need to be in yaml format.
> > 
> > Please put this in the same series as the driver.  
> 
> sooy, I noticed this too late, patches are underway in separate mails 
> now. Hope that isn't a blocking issue?

For next version of either pull them together.

Jonathan

> 
> > 
> > Thanks,
> > 
> > Jonathan
> >   
> >>   1 file changed, 23 insertions(+)
> >>   create mode 100644 Documentation/devicetree/bindings/iio/accel/bmi088.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/iio/accel/bmi088.txt b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
> >> new file mode 100644
> >> index 000000000000..691a47726dbc
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/iio/accel/bmi088.txt
> >> @@ -0,0 +1,23 @@
> >> +* Bosch BMI088 IMU combining accelerometer and gyroscope
> >> +
> >> +https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi088-ds001.pdf
> >> +
> >> +Required properties:
> >> +
> >> +  - compatible : should be "bosch,bmi088_accel"
> >> +  - reg : the I2C address of the sensor or the SPI chip select number
> >> +
> >> +Optional properties:
> >> +
> >> +  - interrupts : interrupt mapping for GPIO IRQ, it should be configured with
> >> +		 IRQ_TYPE_EDGE_RISING
> >> +
> >> +Example:
> >> +
> >> +bmi088_accel@1 {
> >> +	compatible = "bosch,bmi088_accel";
> >> +	reg = <1>;
> >> +	spi-max-frequency = <10000000>;
> >> +	interrupt-parent = <&gpio>;
> >> +	interrupts = <90 IRQ_TYPE_EDGE_RISING>;
> >> +};  
> >   
> 
>