linux-kernel - Re: [PATCH net-next v6 09/10] net: phy: smsc: use phy_read_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50e68879-adf3-52f4-1b0b-334dd02ef85a@gmail.com>
Date:   Sun, 22 Mar 2020 20:17:47 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Dejin Zheng <zhengdejin5@...il.com>, andrew@...n.ch,
        hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
        mchehab+samsung@...nel.org, gregkh@...uxfoundation.org,
        broonie@...nel.org, tglx@...utronix.de, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v6 09/10] net: phy: smsc: use
 phy_read_poll_timeout() to simplify the code



On 3/22/2020 7:56 PM, Dejin Zheng wrote:
> use phy_read_poll_timeout() to replace the poll codes for
> simplify lan87xx_read_status() function.
> 
> it should be add msleep(10) before call phy_read_poll_timeout()
> to keep the code more similar, but it will report that warning, so
> modify it to msleep(20).
> 
> ./scripts/checkpatch.pl
> v5-0009-net-phy-smsc-use-phy_read_poll_timeout-to-simplif.patch
> WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
> #42: FILE: drivers/net/phy/smsc.c:126:
> +		msleep(10);
> 
> Suggested-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Dejin Zheng <zhengdejin5@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian