linux-kernel - Re: [RFC][PATCH 17/22] x86: setup_sigcontext(): list user_access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wg=Bmjzh=CFcngo+xWK7XWMTH=kLWgxtBjsC4a1-9PuPg@mail.gmail.com>
Date:   Mon, 23 Mar 2020 11:56:22 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC][PATCH 17/22] x86: setup_sigcontext(): list
 user_access_{begin,end}() into callers

On Mon, Mar 23, 2020 at 11:40 AM Al Viro <viro@...iv.linux.org.uk> wrote:
>
> -static int setup_sigcontext(struct sigcontext __user *sc, void __user *fpstate,
> +static __always_inline int setup_sigcontext(struct sigcontext __user *sc, void __user *fpstate,

Same deal here: just marking it __always_inline is not enough - make
the naming show that this does the unsafe accesses.

So call it "unsafe_setup_sigcontext()" if you're doing unsafe
accesses, so that *EVERYTHING* that gets done in between the
"user_access_begin/end()" is clearly marked as being special.

Not just for objdump, but for people too.

              Linus