linux-kernel - Re: [Outreachy kernel] [PATCH 01/11] Staging: rtl8188eu: hal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200323020425.62dbeebb@elisabeth>
Date:   Mon, 23 Mar 2020 02:04:25 +0100
From:   Stefano Brivio <sbrivio@...hat.com>
To:     Shreeya Patel <shreeya.patel23498@...il.com>
Cc:     Joe Perches <joe@...ches.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Larry.Finger@...inger.net, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH 01/11] Staging: rtl8188eu: hal_com:
 Add space around operators

Hi Shreeya,

On Mon, 23 Mar 2020 04:48:08 +0530
Shreeya Patel <shreeya.patel23498@...il.com> wrote:

> On Sun, 2020-03-22 at 08:09 -0700, Joe Perches wrote:
> > On Sun, 2020-03-22 at 12:27 +0100, Greg KH wrote:  
> 
> Hi Greg and Joe,
> 
> > > On Sun, Mar 22, 2020 at 03:51:13AM +0530, Shreeya Patel wrote:  
> > > > Add space around operators for improving the code
> > > > readability.
> > > > Reported by checkpatch.pl
> > > > 
> > > > git diff -w shows no difference.
> > > > diff of the .o files before and after the changes shows no
> > > > difference.  
> > > 
> > > There is no need to have these two lines on every changelog comment
> > > in
> > > this series :(  
> >   
> Yes I get that.
> 
> > In my opinion, there's no need for a series here.
> > 
> > Whitespace only changes _should_ be done all at once.
> > 
> > Whitespace changes _could_ have changed string constants.
> > 
> > So noting that the patch in only whitespace and that
> > there isn't a difference in object files is useful as
> > it shows any change has been compiled and tested.
> >   
> 
> Joe, I feel the same thing, there is no need of a patch series
> for it but I was given a suggestion that it becomes difficult for the
> reviewers to review the patch so it is good to send a patchset instead.

In this case, reviewing the 224 lines you're touching in one shot feels
the same as reviewing them over 11 patches, as the change is always of
the same type. Maybe a single patch is actually even a bit quicker to
review.

Are you sure the suggestion was referring to this, and it wasn't about
different type of changes in the same patch?

-- 
Stefano