[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAFd5g44R6yTQENSsS+LSnQppzO=gDVfPB-TxLn_+aT8UpLiTcQ@mail.gmail.com>
Date: Mon, 23 Mar 2020 12:24:50 -0700
From: Brendan Higgins <brendanhiggins@...gle.com>
To: shuah <shuah@...nel.org>
Cc: David Gow <davidgow@...gle.com>,
Heidi Fahim <heidifahim@...gle.com>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@...r.kernel.org>,
KUnit Development <kunit-dev@...glegroups.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] kunit: tool: add missing test data file content
On Mon, Mar 23, 2020 at 12:15 PM Brendan Higgins
<brendanhiggins@...gle.com> wrote:
>
> On Mon, Mar 23, 2020 at 11:44 AM shuah <shuah@...nel.org> wrote:
> >
> > On 3/23/20 11:36 AM, Brendan Higgins wrote:
> > > A test data file for one of the kunit_tool unit tests was missing; add
> > > it in so that unit tests can run properly.
> > >
> > > Signed-off-by: Brendan Higgins <brendanhiggins@...gle.com>
> > > ---
> > > Shuah, this is a fix for a broken test. Can you apply this for 5.7?
> >
> > Can you please add more details on what kind of data this file supplies
> > and which test fails if it doesn't exist.
>
> Sure,
>
> This adds a raw dmesg test log to test the kunit_tool's dmesg parser.
> test_prefix_poundsign and test_output_with_prefix_isolated_correctly
> fail without this test log.
>
> I will send a new revision with this information in the commit message.
I just sent a new revision with an updated message.
Powered by blists - more mailing lists