[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <887add8e-cc74-b50b-46f8-f51d39c12dff@redhat.com>
Date: Mon, 23 Mar 2020 20:39:58 +0100
From: Paolo Bonzini <pbonzini@...hat.com>
To: Nick Desaulniers <ndesaulniers@...gle.com>,
Alexander Potapenko <glider@...gle.com>
Cc: Dmitry Vyukov <dvyukov@...gle.com>,
syzbot <syzbot+3f29ca2efb056a761e38@...kaller.appspotmail.com>,
clang-built-linux <clang-built-linux@...glegroups.com>,
Borislav Petkov <bp@...en8.de>,
"H. Peter Anvin" <hpa@...or.com>,
Jim Mattson <jmattson@...gle.com>,
Joerg Roedel <joro@...tes.org>, KVM list <kvm@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>,
Ingo Molnar <mingo@...hat.com>,
syzkaller-bugs <syzkaller-bugs@...glegroups.com>,
Thomas Gleixner <tglx@...utronix.de>,
Vitaly Kuznetsov <vkuznets@...hat.com>,
Wanpeng Li <wanpengli@...cent.com>,
the arch/x86 maintainers <x86@...nel.org>,
Sean Christopherson <sean.j.christopherson@...el.com>
Subject: Re: BUG: unable to handle kernel NULL pointer dereference in
handle_external_interrupt_irqoff
On 23/03/20 20:30, Nick Desaulniers wrote:
> <ndesaulniers@...gle.com> wrote:
>> So maybe we can find why
>> commit 76b043848fd2 ("x86/retpoline: Add initial retpoline support")
>> added THUNK_TARGET with and without "m" constraint, and either:
>> - remove "m" from THUNK_TARGET. (Maybe this doesn't compile somewhere)
>> or
>> - use my above recommendation locally avoiding THUNK_TARGET. We can
>> use "r" rather than "a" (what Clang would have picked) or "b (what GCC
>> would have picked) to give the compilers maximal flexibility.
> So I've sent a patch for the latter; my reason for not pursuing the former is:
> 1. I assume that the thunk target could be spilled, or a pointer, and
> we'd like to keep flexibility for the general case of inline asm that
> doesn't modify the stack pointer.
> 2. `entry` is local to `handle_external_interrupt_irqoff`; it's not
> being passed in via pointer as a function parameter.
> 3. register pressure is irrelevant if the resulting code is incorrect.
Yes, this is fair enough. I've queued your patch and will send it
shortly to Linus.
Paolo
Powered by blists - more mailing lists