linux-kernel - Re: [PATCH] rearrange the output text, cosmetic changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Mar 2020 08:15:33 -0700
From:   Joe Perches <joe@...ches.com>
To:     Bhaskar Chowdhury <unixbhaskar@...il.com>, linux@...mhuis.info,
        rdunlap@...radead.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rearrange the output text, cosmetic changes

On Tue, 2020-03-24 at 14:15 +0530, Bhaskar Chowdhury wrote:
> As the subject like says, purely cosmetic changes to read cleanly.
> Jumbled up the line.

Subject line should show tools or kernel-chktaint

and:

> diff --git a/tools/debugging/kernel-chktaint b/tools/debugging/kernel-chktaint
[]
> @@ -195,8 +195,9 @@ else
>  	echo " * kernel was built with the struct randomization plugin (#17)"
>  fi
> 
> -echo "For a more detailed explanation of the various taint flags see"
> -echo " Documentation/admin-guide/tainted-kernels.rst in the the Linux kernel sources"
> -echo " or https://kernel.org/doc/html/latest/admin-guide/tainted-kernels.html"
>  echo "Raw taint value as int/string: $taint/'$out'"
> +echo
> +echo "For a more detailed explanation of the various taint flags see below pointers:"
> +echo "1) Documentation/admin-guide/tainted-kernels.rst in  the Linux kernel sources"

One extra space between "in  the"