lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Mar 2020 16:31:28 +0100 From: Peter Zijlstra <peterz@...radead.org> To: tglx@...utronix.de, jpoimboe@...hat.com Cc: linux-kernel@...r.kernel.org, x86@...nel.org, peterz@...radead.org, mhiramat@...nel.org, mbenes@...e.cz, brgerst@...il.com Subject: [PATCH v3 15/26] objtool: Delete cleanup() Perf shows we spend a measurable amount of time spend cleaning up right before we exit anyway. Avoid the needsless work and just terminate. This reduces objtool on vmlinux.o runtime from 5.4s to 4.8s Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org> Acked-by: Josh Poimboeuf <jpoimboe@...hat.com> --- tools/objtool/check.c | 19 ------------------- 1 file changed, 19 deletions(-) --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -2476,23 +2476,6 @@ static int validate_reachable_instructio return 0; } -static void cleanup(struct objtool_file *file) -{ - struct instruction *insn, *tmpinsn; - struct alternative *alt, *tmpalt; - - list_for_each_entry_safe(insn, tmpinsn, &file->insn_list, list) { - list_for_each_entry_safe(alt, tmpalt, &insn->alts, list) { - list_del(&alt->list); - free(alt); - } - list_del(&insn->list); - hash_del(&insn->hash); - free(insn); - } - elf_close(file->elf); -} - static struct objtool_file file; int check(const char *_objname, bool orc) @@ -2560,8 +2543,6 @@ int check(const char *_objname, bool orc } out: - cleanup(&file); - if (ret < 0) { /* * Fatal error. The binary is corrupt or otherwise broken in
Powered by blists - more mailing lists