linux-kernel - Re: [PATCH net v2] netlink: check for null extack in cookie helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200323.212008.1786774265459415637.davem@davemloft.net>
Date:   Mon, 23 Mar 2020 21:20:08 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mkubecek@...e.cz
Cc:     kuba@...nel.org, netdev@...r.kernel.org, johannes@...solutions.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] netlink: check for null extack in cookie helpers

From: Michal Kubecek <mkubecek@...e.cz>
Date: Sat, 21 Mar 2020 00:46:50 +0100 (CET)

> Unlike NL_SET_ERR_* macros, nl_set_extack_cookie_u64() and
> nl_set_extack_cookie_u32() helpers do not check extack argument for null
> and neither do their callers, as syzbot recently discovered for
> ethnl_parse_header().
> 
> Instead of fixing the callers and leaving the trap in place, add check of
> null extack to both helpers to make them consistent with NL_SET_ERR_*
> macros.
> 
> v2: drop incorrect second Fixes tag
> 
> Fixes: 2363d73a2f3e ("ethtool: reject unrecognized request flags")
> Reported-by: syzbot+258a9089477493cea67b@...kaller.appspotmail.com
> Signed-off-by: Michal Kubecek <mkubecek@...e.cz>

Applied, thanks Michal.