linux-kernel - Re: [PATCH] drivers: firmware: psci: avoid BIT() macro usage in PSCI_1_0_OS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 Mar 2020 19:18:05 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Eugene Syromiatnikov <esyr@...hat.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Mark Rutland <mark.rutland@....com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        "Dmitry V. Levin" <ldv@...linux.org>
Subject: Re: [PATCH] drivers: firmware: psci: avoid BIT() macro usage in PSCI_1_0_OS_INITIATED

On Tue, 24 Mar 2020 at 05:15, Eugene Syromiatnikov <esyr@...hat.com> wrote:
>
> The BIT() macro is not available in UAPI headers, so let's replace
> it with similarly defined _BITUL() macro provided by <linux/const.h>.
>
> Fixes: 60dd1ead65e8 ("drivers: firmware: psci: Announce support for OS initiated suspend mode")
> Signed-off-by: Eugene Syromiatnikov <esyr@...hat.com>

Reviewed-by: Ulf Hansson <ulf.hansson@...aro.org>

Kind regards
Uffe

> ---
>  include/uapi/linux/psci.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/psci.h b/include/uapi/linux/psci.h
> index 2fcad1d..87afdeb 100644
> --- a/include/uapi/linux/psci.h
> +++ b/include/uapi/linux/psci.h
> @@ -12,6 +12,8 @@
>  #ifndef _UAPI_LINUX_PSCI_H
>  #define _UAPI_LINUX_PSCI_H
>
> +#include <linux/const.h>
> +
>  /*
>   * PSCI v0.1 interface
>   *
> @@ -100,7 +102,7 @@
>  #define PSCI_1_0_FEATURES_CPU_SUSPEND_PF_MASK  \
>                         (0x1 << PSCI_1_0_FEATURES_CPU_SUSPEND_PF_SHIFT)
>
> -#define PSCI_1_0_OS_INITIATED                  BIT(0)
> +#define PSCI_1_0_OS_INITIATED                  _BITUL(0)
>  #define PSCI_1_0_SUSPEND_MODE_PC               0
>  #define PSCI_1_0_SUSPEND_MODE_OSI              1
>
> --
> 2.1.4
>