linux-kernel - Re: lockdep warning in urb.c:363 usb_submit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.2003241445210.8484-100000@netrider.rowland.org>
Date:   Tue, 24 Mar 2020 15:22:24 -0400 (EDT)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Qais Yousef <qais.yousef@....com>
cc:     Oliver Neukum <oneukum@...e.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: lockdep warning in urb.c:363 usb_submit_urb

On Tue, 24 Mar 2020, Qais Yousef wrote:

> On 03/24/20 11:56, Alan Stern wrote:

> > This certainly reinforces the initial impression that the cause of the
> > warnings is a bug in the platform code.  You should ask the appropriate
> > maintainer.
> 
> The device-tree compatible node returns "generic-ohci".
> drivers/usb/host/ohci-platform.c returns you as the maintainer :-)

I'm the maintainer of the driver for the device.  But the device
structure itself (the one named 7ffb0000.ohci) gets created by 
device-tree -- that's what I was referring to.

Here's the first error message:

usb usb2: runtime PM trying to activate child device usb2 but parent (7ffb0000.ohci) is not active

The runtime PM status of 7ffb0000.ohci is set in ohci_platform_probe(),
which does:

        pm_runtime_set_active(&dev->dev);

The runtime PM status can change, and there aren't any debugging 
statements in ohci_platform_suspend() or ohci_platform_resume() (or 
ohci_suspend()/ohci_resume() in ohci-hcd.c, for that matter).  Maybe 
you can add some so we can see if anything strange is going on.

Any maybe you can find out exactly where that error message is coming 
from by calling dump_stack() immediately after the dev_err() line 
(approximately line 1198 in drivers/base/power/runtime.c).

(Also, you might want to turn off rcutorture.  It adds a lot of 
messages to the system log that are irrelevant for our purposes.)

Alan Stern