linux-kernel - RE: [PATCH v3] i2c: nvidia-gpu: Handle timeout correctly in gpu_i2c_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR12MB27273959932290518B68800ADCF10@BYAPR12MB2727.namprd12.prod.outlook.com>
Date:   Tue, 24 Mar 2020 21:16:49 +0000
From:   Ajay Gupta <ajayg@...dia.com>
To:     Wolfram Sang <wsa@...-dreams.de>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>
CC:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "open list:I2C CONTROLLER DRIVER FOR NVIDIA GPU" 
        <linux-i2c@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3] i2c: nvidia-gpu: Handle timeout correctly in
 gpu_i2c_check_status()

Hi Wolfram,

> -----Original Message-----
> From: Wolfram Sang <wsa@...-dreams.de>
> Sent: Tuesday, March 24, 2020 1:58 PM
> To: Kai-Heng Feng <kai.heng.feng@...onical.com>
> Cc: Ajay Gupta <ajayg@...dia.com>; Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com>; open list:I2C CONTROLLER DRIVER
> FOR NVIDIA GPU <linux-i2c@...r.kernel.org>; open list <linux-
> kernel@...r.kernel.org>
> Subject: Re: [PATCH v3] i2c: nvidia-gpu: Handle timeout correctly in
> gpu_i2c_check_status()
> 
> On Tue, Mar 24, 2020 at 11:28:11PM +0800, Kai-Heng Feng wrote:
> > Nvidia card may come with a "phantom" UCSI device, and its driver gets
> > stuck in probe routine, prevents any system PM operations like suspend.
> >
> > There's an unaccounted case that the target time can equal to jiffies
> > in gpu_i2c_check_status(), let's solve that by using
> > readl_poll_timeout() instead of jiffies comparison functions.
> >
> > Fixes: c71bcdcb42a7 ("i2c: add i2c bus driver for NVIDIA GPU")
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> 
> Looks good to me, thanks Andy for the suggestion!
> 
> Waiting for the Rev-by from Ajay (driver maintainer).
Reviewed-by: Ajay Gupta <ajayg@...dia.com>
Tested-by: Ajay Gupta <ajayg@...dia.com> 

Thanks
Ajay
> nvpublic