linux-kernel - Re: [PATCH] input: avoid BIT() macro usage in the serio.h UAPI header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200324225417.GG75430@dtor-ws>
Date:   Tue, 24 Mar 2020 15:54:17 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Eugene Syromiatnikov <esyr@...hat.com>
Cc:     linux-kernel@...r.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Markus Koch <markus@...syncing.net>,
        "Dmitry V. Levin" <ldv@...linux.org>
Subject: Re: [PATCH] input: avoid BIT() macro usage in the serio.h UAPI header

On Tue, Mar 24, 2020 at 05:13:41AM +0100, Eugene Syromiatnikov wrote:
> The commit 19ba1eb15a2a ("Input: psmouse - add a custom serio protocol
> to send extra information") introduced usage of the BIT() macro
> for SERIO_* flags; this macro is not provided in UAPI headers.
> Replace if with similarly defined _BITUL() macro defined
> in <linux/const.h>.
> 
> Cc: <stable@...r.kernel.org> # v5.0+
> Fixes: 19ba1eb15a2a ("Input: psmouse - add a custom serio protocol to send extra information")
> Signed-off-by: Eugene Syromiatnikov <esyr@...hat.com>

Applied, thank you.

> ---
>  include/uapi/linux/serio.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/include/uapi/linux/serio.h b/include/uapi/linux/serio.h
> index 50e9919..ed2a96f 100644
> --- a/include/uapi/linux/serio.h
> +++ b/include/uapi/linux/serio.h
> @@ -9,7 +9,7 @@
>  #ifndef _UAPI_SERIO_H
>  #define _UAPI_SERIO_H
>  
> -
> +#include <linux/const.h>
>  #include <linux/ioctl.h>
>  
>  #define SPIOCSTYPE	_IOW('q', 0x01, unsigned long)
> @@ -18,10 +18,10 @@
>  /*
>   * bit masks for use in "interrupt" flags (3rd argument)
>   */
> -#define SERIO_TIMEOUT	BIT(0)
> -#define SERIO_PARITY	BIT(1)
> -#define SERIO_FRAME	BIT(2)
> -#define SERIO_OOB_DATA	BIT(3)
> +#define SERIO_TIMEOUT	_BITUL(0)
> +#define SERIO_PARITY	_BITUL(1)
> +#define SERIO_FRAME	_BITUL(2)
> +#define SERIO_OOB_DATA	_BITUL(3)
>  
>  /*
>   * Serio types
> -- 
> 2.1.4
> 

-- 
Dmitry