linux-kernel - Re: [PATCH net-next] cxgb4: remove set but not used variable 'tab'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200324.161011.1071844122704777408.davem@davemloft.net>
Date:   Tue, 24 Mar 2020 16:10:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     yuehaibing@...wei.com
Cc:     vishal@...lsio.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, rahul.lakkireddy@...lsio.com
Subject: Re: [PATCH net-next] cxgb4: remove set but not used variable 'tab'

From: YueHaibing <yuehaibing@...wei.com>
Date: Tue, 24 Mar 2020 14:26:14 +0800

> @@ -544,7 +544,7 @@ int cxgb4_get_free_ftid(struct net_device *dev, u8 family, bool hash_en,
>  {
>  	struct adapter *adap = netdev2adap(dev);
>  	struct tid_info *t = &adap->tids;
> -	struct filter_entry *tab, *f;
> +	struct filter_entry *f;
>  	u32 bmap_ftid, max_ftid;
>  	unsigned long *bmap;
>  	bool found = false;

Please preserve the reverse christmas tree ordering here.