lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Mar 2020 23:45:44 -0700 From: "John B. Wyatt IV" <jbwyatt4@...il.com> To: outreachy-kernel@...glegroups.com, Julia Lawall <julia.lawall@...ia.fr>, Forest Bond <forest@...ttletooquiet.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Quentin Deslandes <quentin.deslandes@...ev.co.uk>, Colin Ian King <colin.king@...onical.com>, Malcolm Priestley <tvboxspy@...il.com>, Oscar Carter <oscar.carter@....com>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Cc: "John B. Wyatt IV" <jbwyatt4@...il.com> Subject: [PATCH 1/2] staging: vt6656: remove unneeded variable: ret Remove unneeded variable ret; replace with 0 for the return value. Update function documentation (comment) on the return status as suggested by Julia Lawall <julia.lawall@...ia.fr>. Issue reported by coccinelle (coccicheck). Signed-off-by: John B. Wyatt IV <jbwyatt4@...il.com> --- drivers/staging/vt6656/card.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c index dc3ab10eb630..05b57a2489a0 100644 --- a/drivers/staging/vt6656/card.c +++ b/drivers/staging/vt6656/card.c @@ -716,13 +716,11 @@ int vnt_radio_power_off(struct vnt_private *priv) * Out: * none * - * Return Value: true if success; otherwise false + * Return Value: 0 * */ int vnt_radio_power_on(struct vnt_private *priv) { - int ret = 0; - vnt_exit_deep_sleep(priv); vnt_mac_reg_bits_on(priv, MAC_REG_HOSTCR, HOSTCR_RXON); @@ -741,7 +739,7 @@ int vnt_radio_power_on(struct vnt_private *priv) vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD); - return ret; + return 0; } void vnt_set_bss_mode(struct vnt_private *priv) -- 2.25.1
Powered by blists - more mailing lists