linux-kernel - Re: [PATCH v2 9/9] x86: replace arch macros from compiler with CONFIG_X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10b5c2da-38cf-c6ba-bdf5-1064f433c3d6@zytor.com>
Date:   Mon, 23 Mar 2020 17:23:32 -0700
From:   "H. Peter Anvin" <hpa@...or.com>
To:     Masahiro Yamada <masahiroy@...nel.org>, x86@...nel.org,
        Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>, linux-crypto@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        "Jason A . Donenfeld" <Jason@...c4.com>
Subject: Re: [PATCH v2 9/9] x86: replace arch macros from compiler with
 CONFIG_X86_{32,64}

On 2020-03-23 17:13, Masahiro Yamada wrote:
> If the intention is to check i386/x86_64 excluding UML,
> checking CONFIG_X86_{32,64} is simpler.
> 
> The reason for checking __i386__ / __x86_64__ was perhaps because
> lib/raid6/algos.c is built not only for the kernel but also for
> testing the library code from userspace.
> 
> However, lib/raid6/test/Makefile passes -DCONFIG_X86_{32,64} for
> this case. So, I do not see a reason to not use CONFIG option here.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>

Acked-by: H. Peter Anvin (Intel) <hpa@...or.com>