linux-kernel - Re: [10/12] mtd: rawnand: stm32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bac5f70c-5e12-2ac1-fc35-46f838f4d480@st.com>
Date:   Tue, 24 Mar 2020 11:38:09 +0100
From:   Christophe Kerello <christophe.kerello@...com>
To:     Marek Vasut <marex@...x.de>, <miquel.raynal@...tlin.com>,
        <richard@....at>, <vigneshr@...com>, <lee.jones@...aro.org>,
        <robh+dt@...nel.org>, <mark.rutland@....com>, <tony@...mide.com>
CC:     <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [10/12] mtd: rawnand: stm32_fmc2: use regmap APIs



On 3/24/20 1:44 AM, Marek Vasut wrote:
> On 3/23/20 3:58 PM, Christophe Kerello wrote:
> [...]
>> @@ -531,11 +515,11 @@ static int stm32_fmc2_nfc_bch_correct(struct nand_chip *chip, u8 *dat,
>>   		return -ETIMEDOUT;
>>   	}
>>   
>> -	ecc_sta[0] = readl_relaxed(nfc->io_base + FMC2_BCHDSR0);
>> -	ecc_sta[1] = readl_relaxed(nfc->io_base + FMC2_BCHDSR1);
>> -	ecc_sta[2] = readl_relaxed(nfc->io_base + FMC2_BCHDSR2);
>> -	ecc_sta[3] = readl_relaxed(nfc->io_base + FMC2_BCHDSR3);
>> -	ecc_sta[4] = readl_relaxed(nfc->io_base + FMC2_BCHDSR4);
>> +	regmap_read(nfc->regmap, FMC2_BCHDSR0, &ecc_sta[0]);
>> +	regmap_read(nfc->regmap, FMC2_BCHDSR1, &ecc_sta[1]);
>> +	regmap_read(nfc->regmap, FMC2_BCHDSR2, &ecc_sta[2]);
>> +	regmap_read(nfc->regmap, FMC2_BCHDSR3, &ecc_sta[3]);
>> +	regmap_read(nfc->regmap, FMC2_BCHDSR4, &ecc_sta[4]);
> 
> Would regmap_bulk_read() work here ?
> 

Hi Marek,

Yes, regmap_bulk_read can be used. It will be done on V2.

Regards,
Christophe Kerello.