linux-kernel - Re: [PATCH 2/2] media: Remove VIDEO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200324114123.121783d7@coco.lan>
Date:   Tue, 24 Mar 2020 11:41:23 +0100
From:   Mauro Carvalho Chehab <mchehab@...nel.org>
To:     Ezequiel Garcia <ezequiel@...labora.com>
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Tomasz Figa <tfiga@...omium.org>,
        Nicolas Dufresne <nicolas@...fresne.ca>, kernel@...labora.com,
        Hans Verkuil <hverkuil@...all.nl>, Sean Young <sean@...s.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Sakari Ailus <sakari.ailus@....fi>,
        Michael Ira Krufky <mkrufky@...il.com>,
        Helen Koike <helen.koike@...labora.com>
Subject: Re: [PATCH 2/2] media: Remove VIDEO_DEV unneeded dependency

Em Tue, 24 Mar 2020 07:18:49 -0300
Ezequiel Garcia <ezequiel@...labora.com> escreveu:

> On Tue, 2020-03-24 at 10:47 +0100, Mauro Carvalho Chehab wrote:
> > Em Mon, 23 Mar 2020 18:10:22 -0300
> > Ezequiel Garcia <ezequiel@...labora.com> escreveu:
> >   
> > > Enable VIDEO_DEV (which compiles Video4Linux core)
> > > when MEDIA_SUPPORT is selected. This is needed, in order
> > > to be able to enable devices such as stateless codecs.
> > > 
> > > Signed-off-by: Ezequiel Garcia <ezequiel@...labora.com>
> > > ---
> > >  drivers/media/Kconfig | 2 --
> > >  1 file changed, 2 deletions(-)
> > > 
> > > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> > > index b36a41332867..7de472ad07a2 100644
> > > --- a/drivers/media/Kconfig
> > > +++ b/drivers/media/Kconfig
> > > @@ -93,13 +93,11 @@ source "drivers/media/mc/Kconfig"
> > >  
> > >  #
> > >  # Video4Linux support
> > > -#	Only enables if one of the V4L2 types (ATV, webcam, radio) is selected
> > >  #
> > >  
> > >  config VIDEO_DEV
> > >  	tristate
> > >  	depends on MEDIA_SUPPORT
> > > -	depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT || MEDIA_SDR_SUPPORT
> > >  	default y
> > >  
> > >  config VIDEO_V4L2_SUBDEV_API  
> > 
> > The rationale of the above is to exclude Digital TV and remote
> > controller.
> > 
> > Removing the above will make the V4L2 core available every time, even
> > if all the user wants is remote controller or Digital TV support.
> >   
> 
> Hm, right.
> 
> > I'm working on a patchset that should hopefully address the issues
> > you're concerning.
> >   
> 
> Thanks, I'll appreciate that.

Sent. Btw, I sent another patch to be applied *after* the series.

It just occurred to me that the best way to make everyone happy is
to let the filtering option to be optional. That's what the newest
patch does ;-)

Thanks,
Mauro