linux-kernel - Re: [PATCH 0/4] KVM: SVM: Move and split up svm.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33af4430-e19d-c414-3e78-bcbc69d5bfb7@redhat.com>
Date:   Tue, 24 Mar 2020 12:33:17 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Joerg Roedel <joro@...tes.org>
Cc:     Sean Christopherson <sean.j.christopherson@...el.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Suravee Suthikulpanit <suravee.suthikulpanit@....com>,
        Tom Lendacky <thomas.lendacky@....com>,
        Ashish Kalra <Ashish.Kalra@....com>,
        Brijesh Singh <brijesh.singh@....com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] KVM: SVM: Move and split up svm.c

On 24/03/20 10:41, Joerg Roedel wrote:
> Hi,
> 
> here is a patch-set agains kvm/queue which moves svm.c into its own
> subdirectory arch/x86/kvm/svm/ and splits moves parts of it into
> separate source files:
> 
> 	- The parts related to nested SVM to nested.c
> 
> 	- AVIC implementation to avic.c
> 
> 	- The SEV parts to sev.c
> 
> I have tested the changes in a guest with and without SEV.
> 
> Please review.
> 
> Thanks,
> 
> 	Joerg
> 
> Joerg Roedel (4):
>   kVM SVM: Move SVM related files to own sub-directory
>   KVM: SVM: Move Nested SVM Implementation to nested.c
>   KVM: SVM: Move AVIC code to separate file
>   KVM: SVM: Move SEV code to separate file
> 
>  arch/x86/kvm/Makefile                 |    2 +-
>  arch/x86/kvm/svm/avic.c               | 1025 ++++
>  arch/x86/kvm/svm/nested.c             |  823 ++++
>  arch/x86/kvm/{pmu_amd.c => svm/pmu.c} |    0
>  arch/x86/kvm/svm/sev.c                | 1178 +++++
>  arch/x86/kvm/{ => svm}/svm.c          | 6546 ++++++-------------------
>  arch/x86/kvm/svm/svm.h                |  491 ++
>  7 files changed, 5106 insertions(+), 4959 deletions(-)
>  create mode 100644 arch/x86/kvm/svm/avic.c
>  create mode 100644 arch/x86/kvm/svm/nested.c
>  rename arch/x86/kvm/{pmu_amd.c => svm/pmu.c} (100%)
>  create mode 100644 arch/x86/kvm/svm/sev.c
>  rename arch/x86/kvm/{ => svm}/svm.c (56%)
>  create mode 100644 arch/x86/kvm/svm/svm.h
> 

Queued, thanks (only cursorily reviewed for now).

Paolo