linux-kernel - Re: [PATCH] drm/vkms: enable cursor by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200324120524.qz2lxzmialjdp3mj@outlook.office365.com>
Date:   Tue, 24 Mar 2020 08:05:24 -0400
From:   Rodrigo Siqueira <Rodrigo.Siqueira@....com>
To:     Melissa Wen <melissa.srw@...il.com>
Cc:     Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>,
        Haneen Mohammed <hamohammed.sa@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/vkms: enable cursor by default

Hi Melissa,

First of all, thanks for your patch.

I agree with you, it makes more sense to me if we enable cursors by
default. I don't remember why we decided to add it as a disabled by
default.

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@....com>

On 03/21, Melissa Wen wrote:
> This patch proposes a change in the behavior of the cursor to enable it as
> soon as the vkms module is added. Enabling the cursor by default appears
> to be an expected and more friendly behavior, especially when running IGT
> tests.
> 
> Signed-off-by: Melissa Wen <melissa.srw@...il.com>
> ---
>  drivers/gpu/drm/vkms/vkms_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 860de052e820..6e6feecf7f20 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -34,7 +34,7 @@
>  
>  static struct vkms_device *vkms_device;
>  
> -bool enable_cursor;
> +bool enable_cursor = true;
>  module_param_named(enable_cursor, enable_cursor, bool, 0444);
>  MODULE_PARM_DESC(enable_cursor, "Enable/Disable cursor support");
>  
> -- 
> 2.25.1
> 

-- 
Rodrigo Siqueira
https://siqueira.tech

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)