linux-kernel - Re: [PATCH v4 0/2] nvmem: use is_bin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 25 Mar 2020 19:24:59 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     linux-kernel@...r.kernel.org,
        nicholas.johnson-opensource@...look.com.au
Subject: Re: [PATCH v4 0/2] nvmem: use is_bin_visible callback

On Wed, Mar 25, 2020 at 01:19:49PM +0000, Srinivas Kandagatla wrote:
> As suggested I managed to use is_bin_visible for the existing code
> and also added few more checks for callbacks before setting
> permissions on the file. Which also means that Thunderbolt case
> for write-only should be fixed automatically with this patch.
> 
> As part of this cleanup it does not make any sense to keep
> nvmem-sysfs.c and nvmem.h anymore, so move all the relevant
> code to core.c
> 
> Changes since v3:
> 	- Split patch2 in to two patches for better review.
> 	- drop first patch to add root_only as its queued

Much nicer, and easier to follow, thanks for doing that.

All now queued up, if I've missed anything, please let me know.

greg k-h