linux-kernel - Re: [PATCH v9 13/55] Input: atmel_mxt_ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <672615bc-adce-213f-9e44-864163c0a770@gmail.com>
Date:   Wed, 25 Mar 2020 22:05:39 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Jiada Wang <jiada_wang@...tor.com>, nick@...anahar.org,
        dmitry.torokhov@...il.com, jikos@...nel.org,
        benjamin.tissoires@...hat.com, bsz@...ihalf.com,
        rydberg@...math.org
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        erosca@...adit-jv.com, Andrew_Gabbasov@...tor.com
Subject: Re: [PATCH v9 13/55] Input: atmel_mxt_ts - add regulator control
 support

25.03.2020 16:32, Jiada Wang пишет:
> From: Nick Dyer <nick.dyer@...ev.co.uk>
> 
> Allow the driver to optionally manage enabling/disable power to the touch
> controller itself. If the regulators are not present then use the deep
> sleep power mode instead.
> 
> For a correct power on sequence, it is required that we have control over
> the RESET line.

...
> +	data->reg_vdd = devm_regulator_get(dev, "vdd");
> +	if (IS_ERR(data->reg_vdd)) {
> +		error = PTR_ERR(data->reg_vdd);
> +		dev_err(dev, "Error %d getting vdd regulator\n", error);
> +		goto fail;
> +	}
> +
> +	data->reg_avdd = devm_regulator_get(dev, "avdd");
> +	if (IS_ERR(data->reg_avdd)) {
> +		error = PTR_ERR(data->reg_avdd);
> +		dev_err(dev, "Error %d getting avdd regulator\n", error);
> +		goto fail_release;
> +	}

Hello Jiada,

The new regulator properties should be documented in the device-tree
binding.