linux-kernel - Re: [PATCH] netfilter/nf_tables: silence a RCU-list warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 26 Mar 2020 00:13:50 +0100
From:   Florian Westphal <fw@...len.de>
To:     Qian Cai <cai@....pw>
Cc:     pablo@...filter.org, kadlec@...filter.org, fw@...len.de,
        davem@...emloft.net, netfilter-devel@...r.kernel.org,
        coreteam@...filter.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfilter/nf_tables: silence a RCU-list warning

Qian Cai <cai@....pw> wrote:
> It is safe to traverse &net->nft.tables with &net->nft.commit_mutex
> held using list_for_each_entry_rcu(). Silence the PROVE_RCU_LIST false
> positive,

[..]

> -	list_for_each_entry_rcu(table, &net->nft.tables, list) {
> +	list_for_each_entry_rcu(table, &net->nft.tables, list,
> +				lockdep_is_held(&net->nft.commit_mutex)) {

Thanks for the patch.

Acked-by: Florian Westphal <fw@...len.de>