linux-kernel - Re: [PATCH] mtd:Fix issue where write_cached_data() fails but write() still returns success

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b37235a2-d949-7f78-770b-4a69d9d7aaaa@huawei.com>
Date:   Wed, 25 Mar 2020 15:53:41 +0800
From:   Xiaoming Ni <nixiaoming@...wei.com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
CC:     <richard@....at>, <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <zhangweimin12@...wei.com>, <wangle6@...wei.com>
Subject: Re: [PATCH] mtd:Fix issue where write_cached_data() fails but write()
 still returns success

On 2020/3/25 6:06, Miquel Raynal wrote:
> Hi Xiaoming,
> 
> Xiaoming Ni <nixiaoming@...wei.com> wrote on Fri, 20 Mar 2020 11:15:11
> +0800:
> 
>> mtdblock_flush()
>> 	-->write_cached_data()
>> 		--->erase_write()
>> 		     mtdblock: erase of region [0x40000, 0x20000] on "xxx" failed
>>
>> Because mtdblock_flush() always returns 0,
>> even if write_cached_data() fails and data is not written to the device,
>> syscall_write() still returns success
> 
> I reworded a bit the commit log and also added a ' ' after 'mtd:' in
> the title when applying.
> 
> Thanks,
> Miquèl

Your revised commit log is more accurate and clearer, thanks for your 
correction
Thanks.
Xiaoming Ni