linux-kernel - Re: [PATCH] dt-bindings: thermal: make cooling-maps property optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a5d398ac-1ec7-487d-cfe6-82698b683237@linaro.org>
Date:   Wed, 25 Mar 2020 10:08:20 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Amit Kucheria <amit.kucheria@...aro.org>
Cc:     Yuantian Tang <andy.tang@....com>, Zhang Rui <rui.zhang@...el.com>,
        Linux PM list <linux-pm@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: thermal: make cooling-maps property optional

On 25/03/2020 07:37, Amit Kucheria wrote:
> On Mon, Mar 16, 2020 at 9:43 PM Amit Kucheria <amit.kucheria@...aro.org> wrote:
>>
>> On Mon, Mar 16, 2020 at 8:22 PM Daniel Lezcano
>> <daniel.lezcano@...aro.org> wrote:
>>>
>>> On 09/03/2020 05:54, andy.tang@....com wrote:
>>>> From: Yuantian Tang <andy.tang@....com>
>>>>
>>>> Cooling-maps doesn't have to be a required property because there may
>>>> be no cooling device on system, or there are no enough cooling devices for
>>>> each thermal zone in multiple thermal zone cases since cooling devices
>>>> can't be shared.
>>>> So make this property optional to remove such limitations.
>>>>
>>>> For thermal zones with no cooling-maps, there could be critic trips
>>>> that can trigger CPU reset or shutdown. So they still can take actions.
>>>>
>>>> Signed-off-by: Yuantian Tang <andy.tang@....com>
>>
>> Reviewed-by: Amit Kucheria <amit.kucheria@...aro.org>
>>
>>>
>>> Amit, I'm about to pick this patch, it will collide with the yaml
>>> conversion changes.
>>
>> Thanks for the headsup. I can fixup v3 when I respin.
>>
>> However, I've always interpreted this binding as follows:
>> - cooling-maps should be mandatory for active and passive trip types
>> otherwise there will be no cooling
>> - cooling-maps make no sense for critical trip type since we're
>> invoking system shutdown
>> - cooling-maps are optional for hot trip types.
>>
>> Is this your understanding too?
>>
>> We should be able to enforce this in YAML.
> 
> Rui, Daniel,
> 
> What do you think about the above interpretation of the cooling-maps bindings?

Yes, I agree with the interpretation.


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog