linux-kernel - Re: [PATCH v3 06/26] objtool: Optimize find_symbol_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2003251058510.12098@pobox.suse.cz>
Date:   Wed, 25 Mar 2020 11:01:47 +0100 (CET)
From:   Miroslav Benes <mbenes@...e.cz>
To:     Peter Zijlstra <peterz@...radead.org>
cc:     tglx@...utronix.de, jpoimboe@...hat.com,
        linux-kernel@...r.kernel.org, x86@...nel.org, mhiramat@...nel.org,
        brgerst@...il.com
Subject: Re: [PATCH v3 06/26] objtool: Optimize find_symbol_by_index()

On Tue, 24 Mar 2020, Peter Zijlstra wrote:

> The symbol index is object wide, not per section, so it makes no sense
> to have the symbol_hash be part of the section object. By moving it to
> the elf object we avoid the linear sections iteration.
> 
> This reduces the runtime of objtool on vmlinux.o from over 3 hours (I
> gave up) to a few minutes. The defconfig vmlinux.o has around 20k
> sections.
> 
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> Acked-by: Josh Poimboeuf <jpoimboe@...hat.com>

Reviewed-by: Miroslav Benes <mbenes@...e.cz>

M