linux-kernel - RE: [PATCH -next] rtc: fsl-ftm-alarm: remove set but not used variable 'np'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM7PR04MB70165A5F952E4A3FE3A4EF8BEDCE0@AM7PR04MB7016.eurprd04.prod.outlook.com>
Date:   Wed, 25 Mar 2020 01:50:35 +0000
From:   Peng Ma <peng.ma@....com>
To:     YueHaibing <yuehaibing@...wei.com>,
        "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>
CC:     "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next] rtc: fsl-ftm-alarm: remove set but not used
 variable 'np'



>-----Original Message-----
>From: YueHaibing <yuehaibing@...wei.com>
>Sent: 2020年3月24日 15:04
>To: a.zummo@...ertech.it; alexandre.belloni@...tlin.com
>Cc: linux-rtc@...r.kernel.org; linux-kernel@...r.kernel.org; Peng Ma
><peng.ma@....com>; YueHaibing <yuehaibing@...wei.com>
>Subject: [PATCH -next] rtc: fsl-ftm-alarm: remove set but not used variable 'np'
>
>drivers/rtc/rtc-fsl-ftm-alarm.c: In function 'ftm_rtc_probe':
>drivers/rtc/rtc-fsl-ftm-alarm.c:246:22: warning: unused variable 'np'
>[-Wunused-variable]
>  struct device_node *np = pdev->dev.of_node;
>                      ^~
>commit cd49b579e705 ("rtc: fsl-ftm-alarm: enable acpi support") left behind
>this, remove it.
>
>Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>---
> drivers/rtc/rtc-fsl-ftm-alarm.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c index
>c572044ff06e..0f4142b35f38 100644
>--- a/drivers/rtc/rtc-fsl-ftm-alarm.c
>+++ b/drivers/rtc/rtc-fsl-ftm-alarm.c
>@@ -243,7 +243,6 @@ static const struct rtc_class_ops ftm_rtc_ops = {
>
> static int ftm_rtc_probe(struct platform_device *pdev)  {
>-	struct device_node *np = pdev->dev.of_node;
[Peng Ma] Hi, HaiBing,

Thanks for your patch, this patch has already in upstream(https://lore.kernel.org/patchwork/patch/1214014/)

Best Regards,
Peng
> 	int irq;
> 	int ret;
> 	struct ftm_rtc *rtc;
>--
>2.17.1
>