linux-kernel - Re: [PATCH 2/3] gpiolib: use kref in gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 25 Mar 2020 12:35:55 +0100
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Bartosz Golaszewski <brgl@...ev.pl>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Khouloud Touil <ktouil@...libre.com>
Subject: Re: [PATCH 2/3] gpiolib: use kref in gpio_desc

śr., 25 mar 2020 o 12:16 Linus Walleij <linus.walleij@...aro.org> napisał(a):
>
> On Mon, Mar 23, 2020 at 9:44 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> > Hi Linus,
> >
> > what is your decision on this? Because if we don't merge this, then we
> > need to make sure nvmem doesn't call gpiod_put() for descriptors it
> > didn't obtain itself and we should probably fix it this week.
>
> I'm simply just overloaded right now, things related to how the world
> looks etc. Also Torvalds writes in Documentation/process/management-style.rst
> that if someone ask you to make a decision, you are screwed :/
>

I see, yeah the times are uncertain for sure. :(

> Your decision is as good as mine, I'm not smarter in any
> way so if it is urgent send me a pull request for the solution that seems best
> to you, I trust you on this.
>

There are no users right now of the broken interface, so I'll just
send a patch with an appropriate comment to Srinivas for the time
being and we can try to fix it in the next release.

Bartosz