linux-kernel - Re: [PATCH] x86: fix early boot crash on gcc-10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200325133137.GC27261@zn.tnic>
Date:   Wed, 25 Mar 2020 14:31:37 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Sergei Trofimovich <slyfox@...too.org>
Cc:     Jakub Jelinek <jakub@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>, x86@...nel.org,
        Michael Matz <matz@...e.de>
Subject: Re: [PATCH] x86: fix early boot crash on gcc-10

On Tue, Mar 17, 2020 at 03:49:42PM +0100, Borislav Petkov wrote:
> On Tue, Mar 17, 2020 at 03:39:14PM +0100, Jakub Jelinek wrote:
> > That is because the option is called -fno-stack-protector, so one needs to
> > use __attribute__((optimize("no-stack-protector")))
> 
> Ha, that works even! :-)
> 
> And my guest boots.
> 
> I guess we can do that then. Looks like the optimal solution to me.
> 
> Also, I'm assuming older gccs will simply ignore unknown optimize
> options?

Sergei,

wanna send v2 where you add the function attribute to start_secondary()
only instead?

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette