linux-kernel - Re: [PATCH] ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <130efce3-5a04-a813-062b-79f8b4284db8@microchip.com>
Date:   Wed, 25 Mar 2020 15:03:32 +0000
From:   <Codrin.Ciubotariu@...rochip.com>
To:     <colin.king@...onical.com>, <lgirdwood@...il.com>,
        <broonie@...nel.org>, <perex@...ex.cz>, <tiwai@...e.com>,
        <Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <Ludovic.Desroches@...rochip.com>, <alsa-devel@...a-project.org>,
        <linux-arm-kernel@...ts.infradead.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned

On 25.03.2020 15:29, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The signed 1 bit bitfields should be unsigned, so make them unsigned.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>

Thanks!

> ---
>   sound/soc/atmel/mchp-i2s-mcc.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/soc/atmel/mchp-i2s-mcc.c b/sound/soc/atmel/mchp-i2s-mcc.c
> index befc2a3a05b0..3cb63886195f 100644
> --- a/sound/soc/atmel/mchp-i2s-mcc.c
> +++ b/sound/soc/atmel/mchp-i2s-mcc.c
> @@ -239,10 +239,10 @@ struct mchp_i2s_mcc_dev {
>          unsigned int                            frame_length;
>          int                                     tdm_slots;
>          int                                     channels;
> -       int                                     gclk_use:1;
> -       int                                     gclk_running:1;
> -       int                                     tx_rdy:1;
> -       int                                     rx_rdy:1;
> +       unsigned int                            gclk_use:1;
> +       unsigned int                            gclk_running:1;
> +       unsigned int                            tx_rdy:1;
> +       unsigned int                            rx_rdy:1;
>   };
> 
>   static irqreturn_t mchp_i2s_mcc_interrupt(int irq, void *dev_id)
> --
> 2.25.1
>