linux-kernel - Re: [PATCH] parisc: Regenerate parisc defconfigs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0825acd-d875-fa39-4659-b54d259f8b1c@gmx.de>
Date:   Fri, 27 Mar 2020 00:01:19 +0100
From:   Helge Deller <deller@....de>
To:     James Bottomley <James.Bottomley@...senPartnership.com>,
        Guenter Roeck <linux@...ck-us.net>
Cc:     linux-parisc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parisc: Regenerate parisc defconfigs

On 26.03.20 23:47, James Bottomley wrote:
> On Thu, 2020-03-26 at 23:19 +0100, Helge Deller wrote:
>> * Guenter Roeck <linux@...ck-us.net>:
>>> On Mon, Feb 03, 2020 at 10:31:22PM +0100, Helge Deller wrote:
>>>> Regenerate the 32- and 64-bit defconfigs and drop the outdated
>>>> specific
>>>> machine defconfigs for the 712, A500, B160, C3000 and C8000
>>>> workstations.
>>>> ---
>>>>  arch/parisc/configs/712_defconfig           | 181 --------------
>>>> -
>>>>  arch/parisc/configs/a500_defconfig          | 177 --------------
>>>> -
>>>>  arch/parisc/configs/defconfig               | 206 --------------
>>>> ---
>>>
>>> Since the removal of arch/parisc/configs/defconfig, "make
>>> ARCH=parisc
>>> defconfig" results in an endless recursive make loop.
>>
>> Can you please test the patch below?
>> Helge
>>
>> ----
>> [PATCH] parisc: Fix defconfig selection
>>
>> Fix the recursive loop when running "make ARCH=parisc defconfig".
>>
>> Fixes: 84669923e1ed ("parisc: Regenerate parisc defconfigs")
>> Noticed-by: Guenter Roeck <linux@...ck-us.net>
>> Signed-off-by: Helge Deller <deller@....de>
>>
>> diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
>> index 71034b54d74e..3801a2ef9bca 100644
>> --- a/arch/parisc/Kconfig
>> +++ b/arch/parisc/Kconfig
>> @@ -79,6 +79,11 @@ config MMU
>>  config STACK_GROWSUP
>>  	def_bool y
>>
>> +config ARCH_DEFCONFIG
>> +	string
>> +	default "arch/parisc/configs/generic-32bit_defconfig" if
>> !64BIT
>> +	default "arch/parisc/configs/generic-64bit_defconfig" if
>> 64BIT
>> +
>>  config GENERIC_LOCKBREAK
>>  	bool
>>  	default y
>> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
>> index dca8f2de8cf5..628cd8bb7ad8 100644
>> --- a/arch/parisc/Makefile
>> +++ b/arch/parisc/Makefile
>> @@ -34,6 +34,13 @@ CC_ARCHES	= hppa hppa2.0 hppa1.1
>>  LD_BFD		:= elf32-hppa-linux
>>  endif
>>
>> +# select defconfig based on actual architecture
>> +ifeq ($(shell uname -m),parisc64)
>
> This won't work for cross builds.  You should be able to use
> $(CONFIG_64BIT) here, though.

I don't think so... CONFIG_64BIT is set in the config itself.

I'm using crossbuilds, and "make ARCH=parisc defconfig" does work
in the sense that it auto-selects 32bit then:

[deller@...530 linux-2.6]$ uname -m
x86_64
[deller@...530 test]$ make ARCH=parisc defconfig
make: Entering directory '/home/cvs/LINUX/git-kernel/linux-2.6'
make[1]: Entering directory '/home/cvs/LINUX/git-kernel/test'
  GEN     Makefile
  ....
  HOSTLD  scripts/kconfig/conf
*** Default configuration is based on 'generic-32bit_defconfig'
#
# configuration written to .config
#


If you want the 64bit defconfig you can run
make ARCH=parisc generic-64bit_defconfig

Helge