linux-kernel - RE: [EXT] [PATCH v2 2/4] ARM: dts: imx6: Use gpc for FEC interrupt controller to fix wake on LAN.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB3600534A60ACE5E658196053FFCF0@VI1PR0402MB3600.eurprd04.prod.outlook.com>
Date:   Thu, 26 Mar 2020 07:45:59 +0000
From:   Andy Duan <fugang.duan@....com>
To:     Martin Fuzzey <martin.fuzzey@...wbird.group>,
        Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Fabio Estevam <festevam@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Andrew Lunn <andrew@...n.ch>
Subject: RE: [EXT] [PATCH v2 2/4] ARM: dts: imx6: Use gpc for FEC interrupt
 controller to fix wake on LAN.

From: Martin Fuzzey <martin.fuzzey@...wbird.group> Sent: Thursday, March 26, 2020 2:12 AM
> In order to wake from suspend by ethernet magic packets the GPC must be
> used as intc does not have wakeup functionality.
> 
> But the FEC DT node currently uses interrupt-extended, specificying intc, thus
> breaking WoL.
> 
> This problem is probably fallout from the stacked domain conversion as intc
> used to chain to GPC.
> 
> So replace "interrupts-extended" by "interrupts" to use the default parent
> which is GPC.
> 
> Fixes: b923ff6af0d5 ("ARM: imx6: convert GPC to stacked domains")
> 
> Signed-off-by: Martin Fuzzey <martin.fuzzey@...wbird.group>
> ---
>  arch/arm/boot/dts/imx6qdl.dtsi | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index e6b4b85..bc488df 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -1039,9 +1039,8 @@
>                                 compatible = "fsl,imx6q-fec";
>                                 reg = <0x02188000 0x4000>;
>                                 interrupt-names = "int0", "pps";
> -                               interrupts-extended =
> -                                       <&intc 0 118
> IRQ_TYPE_LEVEL_HIGH>,
> -                                       <&intc 0 119
> IRQ_TYPE_LEVEL_HIGH>;
> +                               interrupts = <0 118
> IRQ_TYPE_LEVEL_HIGH>,
> +                                            <0 119
> + IRQ_TYPE_LEVEL_HIGH>;

Please remove the property "/delete-property/interrupts-extended;" in below file:
arch/arm/boot/dts/imx6qp.dtsi
>                                 clocks = <&clks
> IMX6QDL_CLK_ENET>,
>                                          <&clks
> IMX6QDL_CLK_ENET>,
>                                          <&clks
> IMX6QDL_CLK_ENET_REF>;
> --
> 1.9.1