linux-kernel - Re: [PATCH v4 1/1] scsi: ufs: Enable block layer runtime PM for well-known logical units

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 26 Mar 2020 16:17:14 +0800
From:   Stanley Chu <stanley.chu@...iatek.com>
To:     Can Guo <cang@...eaurora.org>
CC:     <asutoshd@...eaurora.org>, <nguyenb@...eaurora.org>,
        <hongwus@...eaurora.org>, <rnayak@...eaurora.org>,
        <linux-scsi@...r.kernel.org>, <kernel-team@...roid.com>,
        <saravanak@...gle.com>, <salyzyn@...gle.com>,
        "Alim Akhtar" <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Bean Huo <beanhuo@...ron.com>,
        "Bart Van Assche" <bvanassche@....org>,
        Venkat Gopalakrishnan <venkatg@...eaurora.org>,
        Tomas Winkler <tomas.winkler@...el.com>,
        "open list" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/1] scsi: ufs: Enable block layer runtime PM for
 well-known logical units

Hi Can,

On Wed, 2020-03-25 at 18:09 -0700, Can Guo wrote:
> Block layer RPM is enabled for the genernal UFS SCSI devices when they are
> probed by their driver. However block layer RPM is not enabled for UFS
> well-known SCSI devices.
> 
> As UFS SCSI devices have their corresponding BSG char devices, accessing
> a BSG char device via IOCTL may send requests to its corresponding SCSI
> device through its request queue. If BSG IOCTL sends a request to a
> well-known SCSI device when hba is not runtime active, due to block layer
> RPM is not eanbled for the well-known SCSI devices, hba, which is at the
> top of a scsi device's parent chain, shall not be resumed, then unexpected
> error would happen.
> 
> This change enables block layer RPM for the well-known SCSI devices, so
> that block layer can handle RPM for the well-known SCSI devices just like
> for the general SCSI devices.
> 
> Signed-off-by: Can Guo <cang@...eaurora.org>
> Reviewed-by: Avri Altman <avri.altman@....com>

Looks good!
Thanks to make RPM for UFS completed!

Reviewed-by: Stanley Chu <stanley.chu@...iatek.com>