linux-kernel - Re: [PATCH] staging: rtl8188eu: cleanup long line in odm.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <147371c7-54f9-3d17-b497-24044aa5c654@gmail.com>
Date:   Thu, 26 Mar 2020 09:45:44 +0100
From:   Michael Straube <straube.linux@...il.com>
To:     Joe Perches <joe@...ches.com>, gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: cleanup long line in odm.c



On 2020-03-26 01:08, Joe Perches wrote:
> On Wed, 2020-03-25 at 22:59 +0100, Michael Straube wrote:
>> Cleanup line over 80 characters by removing unnecessary parentheses.
> []
>> diff --git a/drivers/staging/rtl8188eu/hal/odm.c b/drivers/staging/rtl8188eu/hal/odm.c
> []
>> @@ -590,7 +590,7 @@ void odm_CCKPacketDetectionThresh(struct odm_dm_struct *pDM_Odm)
>>   	if (pDM_Odm->bLinked) {
>>   		if (pDM_Odm->RSSI_Min > 25) {
>>   			CurCCK_CCAThres = 0xcd;
>> -		} else if ((pDM_Odm->RSSI_Min <= 25) && (pDM_Odm->RSSI_Min > 10)) {
>> +		} else if (pDM_Odm->RSSI_Min <= 25 && pDM_Odm->RSSI_Min > 10) {
> 
> The test above this already guarantees pDM_Odm->RSSI_Min <= 25
> so the block could be written just
> 
> 		} else if (pDM->RSSI_Min > 10) {
> 

Ah, yes. Thank you. :)