linux-kernel - Re: [PATCH v4 2/4] mfd: anx7688: Add driver for Analogix ANX7688 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200326093019.GC603801@dell>
Date:   Thu, 26 Mar 2020 09:30:19 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     linux-kernel@...r.kernel.org,
        Collabora Kernel ML <kernel@...labora.com>,
        Andrzej Hajda <a.hajda@...sung.com>, icenowy@...c.io,
        anarsoul@...il.com, Neil Armstrong <narmstrong@...libre.com>,
        matthias.bgg@...il.com, drinkcat@...omium.org, hsinyi@...omium.org,
        megous@...ous.com
Subject: Re: [PATCH v4 2/4] mfd: anx7688: Add driver for Analogix ANX7688 chip

On Wed, 18 Mar 2020, Enric Balletbo i Serra wrote:

> The ANX7688 chip is a Type-C Port Controller, HDMI to DP converter and
> USB-C mux between USB 3.0 lanes and the DP output.
> 
> For our use case a big part of the chip, like power supplies, control
> gpios and usb-c parts are managed by an Embedded Controller, hence,
> this is its simplest form of it. Other users of this chip might
> introduce new functionalities as per their requirements.

Hmm... So first impressions is that this 'driver' doesn't really do
anything useful other than checking the running model.  I think you're
better off using "simple-mfd" and doing the ID check inside the
useful/functional child device driver(s).

> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> ---
> 
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  drivers/mfd/Kconfig         | 11 +++++
>  drivers/mfd/Makefile        |  1 +
>  drivers/mfd/anx7688.c       | 87 +++++++++++++++++++++++++++++++++++++
>  include/linux/mfd/anx7688.h | 39 +++++++++++++++++
>  4 files changed, 138 insertions(+)
>  create mode 100644 drivers/mfd/anx7688.c
>  create mode 100644 include/linux/mfd/anx7688.h

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog