linux-kernel - Re: [PATCH v4 24/27] ata: move ata_sas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200326100003.GR9596@lst.de>
Date:   Thu, 26 Mar 2020 11:00:03 +0100
From:   Christoph Hellwig <hch@....de>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:     Jens Axboe <axboe@...nel.dk>,
        Michael Schmitz <schmitzmic@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Christoph Hellwig <hch@....de>, linux-ide@...r.kernel.org,
        linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 24/27] ata: move ata_sas_*() to libata-sata.c

On Tue, Mar 17, 2020 at 03:43:30PM +0100, Bartlomiej Zolnierkiewicz wrote:
> * un-inline:
>   - ata_scsi_dump_cdb()
>   - __ata_scsi_queuecmd()
> 
> * un-static:
>   - ata_scsi_sdev_config()
>   - ata_scsi_dev_config()
>   - ata_scsi_dump_cdb()
>   - __ata_scsi_queuecmd()
> 
> * move ata_sas_*() to libata-sata.c:
> 
> * add static inlines for CONFIG_SATA_HOST=n case for
>   ata_sas_{allocate,free}_tag()

Looks good,

Reviewed-by: Christoph Hellwig <hch@....de>