linux-kernel - Re: [PATCH v4 26/27] ata: move ata_eh_analyze_ncq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200326100045.GT9596@lst.de>
Date:   Thu, 26 Mar 2020 11:00:45 +0100
From:   Christoph Hellwig <hch@....de>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:     Jens Axboe <axboe@...nel.dk>,
        Michael Schmitz <schmitzmic@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Christoph Hellwig <hch@....de>, linux-ide@...r.kernel.org,
        linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 26/27] ata: move ata_eh_analyze_ncq_error() & co. to
 libata-sata.c

On Tue, Mar 17, 2020 at 03:43:32PM +0100, Bartlomiej Zolnierkiewicz wrote:
> * move ata_eh_analyze_ncq_error() and ata_eh_read_log_10h() to
>   libata-sata.c
> 
> * add static inline for ata_eh_analyze_ncq_error() for
>   CONFIG_SATA_HOST=n case (link->sactive is non-zero only if
>   NCQ commands are actually queued so empty function body is
>   sufficient)

Looks good,

Reviewed-by: Christoph Hellwig <hch@....de>