linux-kernel - Re: linux-next: build failure after merge of the tip tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200326105908.enebu3x4lmdvwnnf@e107158-lin>
Date:   Thu, 26 Mar 2020 10:59:09 +0000
From:   Qais Yousef <qais.yousef@....com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
        "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Sebastian Reichel <sre@...nel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Baolin Wang <baolin.wang7@...il.com>
Subject: Re: linux-next: build failure after merge of the tip tree

Hi Stephen

On 03/26/20 13:52, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/power/reset/sc27xx-poweroff.c: In function 'sc27xx_poweroff_shutdown':
> drivers/power/reset/sc27xx-poweroff.c:38:4: error: implicit declaration of function 'cpu_down' [-Werror=implicit-function-declaration]
>    38 |    cpu_down(cpu);
>       |    ^~~~~~~~
> 
> Caused by commit
> 
>   33c3736ec888 ("cpu/hotplug: Hide cpu_up/down()")
> 
> interacting with commit
> 
>   274afbc3ad33 ("power: reset: sc27xx: Change to use cpu_down()")
> 
> from the battery tree.
> 
> I have added the following merge fix patch:

Your merge fix looks correct.

Though the original code is missing error handling if offlining the cpu failed
for one reason or another.

I don't know the details, but something feels off about the driver having to
bring cpus down.

Thanks

--
Qais Yousef

> 
> From: Stephen Rothwell <sfr@...b.auug.org.au>
> Date: Thu, 26 Mar 2020 13:42:00 +1100
> Subject: [PATCH] power: reset: sc27xx: use remove_cpu instead of cpu_down
> 
> Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
> ---
>  drivers/power/reset/sc27xx-poweroff.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/reset/sc27xx-poweroff.c b/drivers/power/reset/sc27xx-poweroff.c
> index 69863074daf6..90287c31992c 100644
> --- a/drivers/power/reset/sc27xx-poweroff.c
> +++ b/drivers/power/reset/sc27xx-poweroff.c
> @@ -35,7 +35,7 @@ static void sc27xx_poweroff_shutdown(void)
>  
>  	for_each_online_cpu(cpu) {
>  		if (cpu != smp_processor_id())
> -			cpu_down(cpu);
> +			remove_cpu(cpu);
>  	}
>  #endif
>  }
> -- 
> 2.25.0
> 
> -- 
> Cheers,
> Stephen Rothwell