linux-kernel - Re: [PATCH 1/2] driver core: platform: Initialize dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbFQ4kjgxxwrTjXZWAt38AM2kyMbeaCX6wjMgyyRmE55Q@mail.gmail.com>
Date:   Thu, 26 Mar 2020 12:01:28 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>, Christoph Hellwig <hch@....de>,
        Russell King <linux@...linux.org.uk>,
        Vinod Koul <vkoul@...nel.org>, Haibo Chen <haibo.chen@....com>,
        Ludovic Barre <ludovic.barre@...com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        dmaengine <dmaengine@...r.kernel.org>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH 1/2] driver core: platform: Initialize dma_parms for
 platform devices

On Wed, Mar 25, 2020 at 12:34 PM Ulf Hansson <ulf.hansson@...aro.org> wrote:

> It's currently the platform driver's responsibility to initialize the
> pointer, dma_parms, for its corresponding struct device. The benefit with
> this approach allows us to avoid the initialization and to not waste memory
> for the struct device_dma_parameters, as this can be decided on a case by
> case basis.
>
> However, it has turned out that this approach is not very practical.  Not
> only does it lead to open coding, but also to real errors. In principle
> callers of dma_set_max_seg_size() doesn't check the error code, but just
> assumes it succeeds.
>
> For these reasons, let's do the initialization from the common platform bus
> at the device registration point. This also follows the way the PCI devices
> are being managed, see pci_device_add().
>
> Suggested-by: Christoph Hellwig <hch@....de>
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>

This seems in line with what Christoph said.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

I imagine we can eventually set up more of the DMA config such
as segment size based on config from the device tree, but I'm not
sure about that yet.

Yours,
Linus Walleij