[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <TYAPR01MB454468B739FE4C4CFFF51801D8CF0@TYAPR01MB4544.jpnprd01.prod.outlook.com>
Date: Thu, 26 Mar 2020 02:16:22 +0000
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
CC: Kishon Vijay Abraham I <kishon@...com>,
Rob Herring <robh+dt@...nel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH 1/2] dt-bindings: phy: rcar-gen3-phy-usb2: add r8a77961
support
Hi Geert-san,
Thank you for your review!
> From: Geert Uytterhoeven, Sent: Wednesday, March 25, 2020 10:07 PM
<snip>
> > --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> > +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt
> > @@ -18,6 +18,8 @@ Required properties:
> > SoC.
> > "renesas,usb2-phy-r8a7796" if the device is a part of an R8A7796
>
> While at it, you may want to update "r8A7796 SoC" to "r8A77960 SoC", to
> avoid confusion between R-Car M3-W (R8A77960) and M3-W+ (R8A77961).
>
> Note that rebasing this patch on top of your "[PATCH v2] dt-bindings:
> phy: renesas: usb2-phy: convert bindings to json-schema"
> (https://lore.kernel.org/linux-devicetree/1572592763-12396-1-git-send-email-yoshihiro.shimoda.uh@renesas.com/)
> would avoid that, too.
I completely forgot about the patch I made...
So, I'll rebase this patch on the .yaml.
> > SoC.
> > + "renesas,usb2-phy-r8a77961" if the device is a part of an
> > + R8A77961 SoC.
> > "renesas,usb2-phy-r8a77965" if the device is a part of an
> > R8A77965 SoC.
> > "renesas,usb2-phy-r8a77990" if the device is a part of an
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
Thanks!
Best regards,
Yoshihiro Shimoda
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Powered by blists - more mailing lists