linux-kernel - Re: [PATCH bpf-next v6 1/8] bpf: Introduce BPF_PROG_TYPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200326131158.GA8575@chromium.org>
Date:   Thu, 26 Mar 2020 14:11:58 +0100
From:   KP Singh <kpsingh@...omium.org>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     open list <linux-kernel@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, linux-security-module@...r.kernel.org,
        Brendan Jackman <jackmanb@...gle.com>,
        Florent Revest <revest@...gle.com>,
        Thomas Garnier <thgarnie@...gle.com>,
        Yonghong Song <yhs@...com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        James Morris <jmorris@...ei.org>,
        Kees Cook <keescook@...omium.org>,
        Paul Turner <pjt@...gle.com>, Jann Horn <jannh@...gle.com>,
        Florent Revest <revest@...omium.org>,
        Brendan Jackman <jackmanb@...omium.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH bpf-next v6 1/8] bpf: Introduce BPF_PROG_TYPE_LSM

On 25-Mär 18:51, Andrii Nakryiko wrote:
> On Wed, Mar 25, 2020 at 8:27 AM KP Singh <kpsingh@...omium.org> wrote:
> >
> > From: KP Singh <kpsingh@...gle.com>
> >
> > Introduce types and configs for bpf programs that can be attached to
> > LSM hooks. The programs can be enabled by the config option
> > CONFIG_BPF_LSM.
> >
> > Signed-off-by: KP Singh <kpsingh@...gle.com>
> > Reviewed-by: Brendan Jackman <jackmanb@...gle.com>
> > Reviewed-by: Florent Revest <revest@...gle.com>
> > Reviewed-by: Thomas Garnier <thgarnie@...gle.com>
> > Acked-by: Yonghong Song <yhs@...com>
> > ---
> 
> Looks good to me, so please add by ack, but I think it would be easier
> to review if this was combined with patch #4, which adds verifier
> support and kernel/bpf/syscall.c support. On its own this patch just
> adds random unused stuff.

The ordering becomes tricky as we are using the CONFIG_BPF_LSM in
"bpf: lsm: provide attachment points for BPF LSM
programs". If it's not too much trouble, I would appreciate if we can
keep the order.

> 
> Acked-by: Andrii Nakryiko <andriin@...com>

Added your ack Thanks :)

- KP

> 
> >  MAINTAINERS                    |  1 +
> >  include/linux/bpf.h            |  3 +++
> >  include/linux/bpf_types.h      |  4 ++++
> >  include/uapi/linux/bpf.h       |  2 ++
> >  init/Kconfig                   | 12 ++++++++++++
> >  kernel/bpf/Makefile            |  1 +
> >  kernel/bpf/bpf_lsm.c           | 17 +++++++++++++++++
> >  kernel/trace/bpf_trace.c       | 12 ++++++------
> >  tools/include/uapi/linux/bpf.h |  2 ++
> >  tools/lib/bpf/libbpf_probes.c  |  1 +
> >  10 files changed, 49 insertions(+), 6 deletions(-)
> >  create mode 100644 kernel/bpf/bpf_lsm.c
> >
> 
> [...]