linux-kernel - Re: [RESEND][PATCH v3 07/17] static_call: Add inline static call infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200326155425.GE11398@zn.tnic>
Date:   Thu, 26 Mar 2020 16:54:25 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org, rostedt@...dmis.org,
        mhiramat@...nel.org, bristot@...hat.com, jbaron@...mai.com,
        torvalds@...ux-foundation.org, tglx@...utronix.de,
        mingo@...nel.org, namit@...are.com, hpa@...or.com, luto@...nel.org,
        ard.biesheuvel@...aro.org, jpoimboe@...hat.com
Subject: Re: [RESEND][PATCH v3 07/17] static_call: Add inline static call
 infrastructure

On Tue, Mar 24, 2020 at 02:56:10PM +0100, Peter Zijlstra wrote:
> +#define DEFINE_STATIC_CALL(name, _func)					\
> +	DECLARE_STATIC_CALL(name, _func);				\
> +	struct static_call_key STATIC_CALL_NAME(name) = {		\
> +		.func = _func,						\
> +		.next = NULL,						\
> +	};								\
> +	__ADDRESSABLE(STATIC_CALL_NAME(name));				\
> +	ARCH_DEFINE_STATIC_CALL_TRAMP(name, _func)
> +
> +#define static_call(name)	STATIC_CALL_TRAMP(name)
> +
> +#define EXPORT_STATIC_CALL(name)					\
> +	EXPORT_SYMBOL(STATIC_CALL_NAME(name));				\
> +	EXPORT_SYMBOL(STATIC_CALL_TRAMP(name))

I think we want only the _GPL versions below - not those. As you said on
IRC, jump_label/static_branch is GPL only.

> +
> +#define EXPORT_STATIC_CALL_GPL(name)					\
> +	EXPORT_SYMBOL_GPL(STATIC_CALL_NAME(name));			\
> +	EXPORT_SYMBOL_GPL(STATIC_CALL_TRAMP(name))

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette