linux-kernel - Re: modpost Module.symver handling is broken in 5.6.0-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200326171453.GA21406@linux-8ccs>
Date:   Thu, 26 Mar 2020 18:14:53 +0100
From:   Jessica Yu <jeyu@...nel.org>
To:     David Laight <David.Laight@...lab.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        'Linus Torvalds' <torvalds@...ux-foundation.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Matthias Maennich <maennich@...gle.com>
Subject: Re: modpost Module.symver handling is broken in 5.6.0-rc7

+++ David Laight [26/03/20 17:06 +0000]:
>From: Jessica Yu
>> Sent: 26 March 2020 16:51
>> +++ David Laight [26/03/20 16:25 +0000]:
>> >Something is currently broken in modpost.
>> >I'm guessing it is down to the recent patch that moved the
>> >namespace back to the end of the line.
>> >
>> >I'm building 2 'out of tree' modules that have a symbol dependency.
>> >When I build the 2nd module I get ERROR "symbol" undefined message.
>> >
>> >If I flip the order of the fields in Module.symver to the older order
>> >and link with modpost from 5.4.0-rc7 (which I happen to have lurking)
>> >it all works fine.
>> >
>> >Note that I'm using a named namespace, not the default one
>> >that is the full path of the module.
>> >
>> >I'll dig in a little further.
>>
>> [ Adding more people to CC ]
>>
>> Hi David,
>>
>> Could you provide some more details about how I can reproduce the
>> issue? As I understand it, you have two out-of-tree modules, and one
>> has a symbol dependency on the second? Pasting the modpost error
>> messages helps too.
>
>Ok, I've found out what broke it.
>Was actually the removal of the code that parsed Module.symvers
>from the current directory (which happened for 5.5.0-rc0).
>
>Took some digging and printfs in modpost to find what wasn't happening.
>
>	David

Hi David,

I'm a bit confused - just to confirm, is there a legitimate bug
upstream or was it just a hiccup related to your setup?

Thanks!

Jessica